addyosmani Github contribution chart
addyosmani Github Stats
addyosmani Most Used Languages

Activity

03 Sep 2022

Addyosmani

[experiment] adjust offset to fix desktop UX

Pushed On 03 Sep 2022 at 11:02:18

Addyosmani

[mobile updates] viewport

Pushed On 03 Sep 2022 at 10:46:30
Issue Comment

Addyosmani

Add fetchpriority for Movies

This change plumbs through fetchpriority for the first image in a set (typically our LCP). For now, mostly adding in to do some testing after experimenting with some wins via the WPT Experiments feature.

https://user-images.githubusercontent.com/110953/188286579-935f880b-1971-4300-a762-1b1f0b2c2778.mp4

link

Forked On 03 Sep 2022 at 08:49:32

Addyosmani

after: https://user-images.githubusercontent.com/110953/188287257-b372ff97-1577-402a-8ade-075f2d3cb721.mp4

Commented On 03 Sep 2022 at 08:49:32

Addyosmani

Further pre-connect cleanup

Pushed On 03 Sep 2022 at 08:41:21

Addyosmani

Add fetchpriority for Movies

This change plumbs through fetchpriority for the first image in a set (typically our LCP).

Pushed On 03 Sep 2022 at 08:24:43

Addyosmani

Merge pull request #15 from tastejs/priority-hints

Add fetchpriority for Movies

Pushed On 03 Sep 2022 at 08:24:43

Addyosmani

Add fetchpriority for Movies

Created On 03 Sep 2022 at 08:24:43
Issue Comment

Addyosmani

Add fetchpriority for Movies

This change plumbs through fetchpriority for the first image in a set (typically our LCP). For now, mostly adding in to do some testing after experimenting with some wins via the WPT Experiments feature.

https://user-images.githubusercontent.com/110953/188286579-935f880b-1971-4300-a762-1b1f0b2c2778.mp4

link

Forked On 03 Sep 2022 at 08:23:25

Addyosmani

For later, here's a HQ before video.

Commented On 03 Sep 2022 at 08:23:25
Issue Comment

Addyosmani

Add fetchpriority for Movies

This change plumbs through fetchpriority for the first image in a set (typically our LCP). For now, mostly adding in to do some testing after experimenting with some wins via the WPT Experiments feature.

https://user-images.githubusercontent.com/110953/188286579-935f880b-1971-4300-a762-1b1f0b2c2778.mp4

link

Forked On 03 Sep 2022 at 08:22:17

Addyosmani

I'm going to go ahead and land this change and do a final prod comparison before wrapping up.

Commented On 03 Sep 2022 at 08:22:17
Issue Comment

Addyosmani

Add fetchpriority for Movies

This change plumbs through fetchpriority for the first image in a set (typically our LCP). For now, mostly adding in to do some testing after experimenting with some wins via the WPT Experiments feature.

https://user-images.githubusercontent.com/110953/188286579-935f880b-1971-4300-a762-1b1f0b2c2778.mp4

Forked On 03 Sep 2022 at 08:21:35

Addyosmani

vs

Commented On 03 Sep 2022 at 08:21:35
Issue Comment

Addyosmani

Add fetchpriority for Movies

This change plumbs through fetchpriority for the first image in a set (typically our LCP). For now, mostly adding in to do some testing after experimenting with some wins via the WPT Experiments feature.

Forked On 03 Sep 2022 at 08:20:18

Addyosmani

Some early comparisons (staging only where things are slower)

vs without

Commented On 03 Sep 2022 at 08:20:18

Addyosmani

Add fetchpriority for Movies

Created On 03 Sep 2022 at 08:16:39
Create Branch
Addyosmani In tastejs/next-movies Create Branchpriority-hints

Addyosmani

A Next.js Movies App

On 03 Sep 2022 at 08:16:14

Addyosmani

Minor README updates.

Pushed On 03 Sep 2022 at 07:29:38

Addyosmani

Merge branch 'main' of https://github.com/tastejs/next-movies

Pushed On 03 Sep 2022 at 07:29:38

Addyosmani

Disable Google Analytics

Most other implementations do not use it.

Pushed On 03 Sep 2022 at 07:20:02

Addyosmani

More dynamic loading

Pushed On 03 Sep 2022 at 07:20:02

Addyosmani

Merge pull request #14 from tastejs/optimizations

Further performance optimizations

Pushed On 03 Sep 2022 at 07:20:02

Addyosmani

Further performance optimizations

Created On 03 Sep 2022 at 07:20:02

Addyosmani

Further performance optimizations

Created On 03 Sep 2022 at 07:11:59
Create Branch
Addyosmani In tastejs/next-movies Create Branchoptimizations

Addyosmani

A Next.js Movies App

On 03 Sep 2022 at 07:10:21

Addyosmani

Upgrade to Next.js 12

  • Upgrades to 12 while remaining on React 17.x
  • Decided not to upgrade to React 18 at this time as we need to dig in further into these particular hydration bugs: https://github.com/vercel/next.js/discussions/35773

Pushed On 03 Sep 2022 at 06:45:06

Addyosmani

Adjust LazyLoad offset

Pushed On 03 Sep 2022 at 06:45:06

Addyosmani

Further adjust offset.

Pushed On 03 Sep 2022 at 06:45:06

Addyosmani

Merge pull request #13 from tastejs/upgrade-latest

Upgrade to Next.js 12

Pushed On 03 Sep 2022 at 06:45:06

Addyosmani

Upgrade to Next.js 12

Created On 03 Sep 2022 at 06:45:06
Issue Comment

Addyosmani

Upgrade to Next.js 12

  • Upgrades to 12 while remaining on React 17.x
  • Decided not to upgrade to React 18 at this time as we need to dig in further into these particular hydration bugs: https://github.com/vercel/next.js/discussions/35773

Additional:

Locally, I'm seeing a new UX issue that isn't on production (with Next 11.x/React 17.x) with only the first 5 images loading while the others initially fail to fetch, then get fixed as you scroll. It isn't immediately clear if this is a temporal problem in DEV or will repro in staging, but going to check before landing this. Issue appears cross-browser.

Update 2: Confirmed this issue is present in staging too. Investigating.

Update 3: Changing the LazyLoad threshold from 200 => 500 appears to address this issue. Will want to check on performance implications, but pushing to staging to look at this further.

Forked On 03 Sep 2022 at 06:44:53

Addyosmani

Okay. The issues with the LazyLoad thresholds should be addressed in https://deploy-preview-13--movies-browser.netlify.app/?category=Popular&page=1.

Commented On 03 Sep 2022 at 06:44:53

Addyosmani

Further adjust offset.

Pushed On 03 Sep 2022 at 06:34:59

Addyosmani

Adjust LazyLoad offset

Pushed On 03 Sep 2022 at 06:28:37

Addyosmani

Upgrade to Next.js 12

Created On 03 Sep 2022 at 06:22:07
Create Branch
Addyosmani In tastejs/next-movies Create Branchupgrade-latest

Addyosmani

A Next.js Movies App

On 03 Sep 2022 at 06:21:03

Addyosmani

Adds "optimizing third-party scripts" blog post (#3409)

  • Add optimizing third-parties post

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Update site/en/blog/third-party-scripts/index.md

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

  • Address additional feedback

  • Update shoutouts section

  • Round of edits.

Co-authored-by: Jeremy Wagner malchata@users.noreply.github.com

Pushed On 18 Aug 2022 at 05:08:57

Addyosmani

Adds "optimizing third-party scripts" blog post

Created On 18 Aug 2022 at 05:08:55