VictorVelarde Github contribution chart
VictorVelarde Github Stats
VictorVelarde Most Used Languages

Activity

20 Sep 2022

VictorVelarde

Feature Selection tool does not work with Satellite Google base map

Description

Shortcut: https://app.shortcut.com/cartoteam/story/241108/ac-z2gigeei-feature-selection-tool-does-not-work-when-terrain-or-satellite-basemap-is-set-on-the-first-action

Nebula editable geojson layerset the billboard property false by default and it looks like it is not compatible with Google Raster base maps. For our use cases, I think that this property is not necessary because is relative to the 3D rendering and the extrusion. More details here

This PR set the billboard property to false and add a test to check this property. Also, increase a bit the layer line with to keep the same look when we set the billboard property to false

Type of change

  • Fix

Merged On 20 Sep 2022 at 02:51:11

VictorVelarde

LGTM

Commented On 20 Sep 2022 at 02:51:11

VictorVelarde

Feature Selection tool does not work with Satellite Google base map

Description

Shortcut: https://app.shortcut.com/cartoteam/story/241108/ac-z2gigeei-feature-selection-tool-does-not-work-when-terrain-or-satellite-basemap-is-set-on-the-first-action

Nebula editable geojson layerset the billboard property false by default and it looks like it is not compatible with Google Raster base maps. For our use cases, I think that this property is not necessary because is relative to the 3D rendering and the extrusion. More details here

This PR set the billboard property to false and add a test to check this property. Also, increase a bit the layer line with to keep the same look when we set the billboard property to false

Type of change

  • Fix

Forked On 20 Sep 2022 at 02:50:23

VictorVelarde

Not sure if just in raster? ```suggestion describe('Google Maps Raster compatibility', () => { ```
On 20 Sep 2022 at 02:50:23

VictorVelarde

Feature Selection tool does not work with Satellite Google base map

Description

Shortcut: https://app.shortcut.com/cartoteam/story/241108/ac-z2gigeei-feature-selection-tool-does-not-work-when-terrain-or-satellite-basemap-is-set-on-the-first-action

Nebula editable geojson layerset the billboard property false by default and it looks like it is not compatible with Google Raster base maps. For our use cases, I think that this property is not necessary because is relative to the 3D rendering and the extrusion. More details here

This PR set the billboard property to false and add a test to check this property. Also, increase a bit the layer line with to keep the same look when we set the billboard property to false

Type of change

  • Fix

Merged On 20 Sep 2022 at 02:50:24

VictorVelarde

Commented On 20 Sep 2022 at 02:50:24

VictorVelarde

Feature Selection tool does not work with Satellite Google base map

Description

Shortcut: https://app.shortcut.com/cartoteam/story/241108/ac-z2gigeei-feature-selection-tool-does-not-work-when-terrain-or-satellite-basemap-is-set-on-the-first-action

Nebula editable geojson layerset the billboard property false by default and it looks like it is not compatible with Google Raster base maps. For our use cases, I think that this property is not necessary because is relative to the 3D rendering and the extrusion. More details here

This PR set the billboard property to false and add a test to check this property. Also, increase a bit the layer line with to keep the same look when we set the billboard property to false

Type of change

  • Fix

Merged On 20 Sep 2022 at 02:49:24

VictorVelarde

Commented On 20 Sep 2022 at 02:49:24

VictorVelarde

Feature Selection tool does not work with Satellite Google base map

Description

Shortcut: https://app.shortcut.com/cartoteam/story/241108/ac-z2gigeei-feature-selection-tool-does-not-work-when-terrain-or-satellite-basemap-is-set-on-the-first-action

Nebula editable geojson layerset the billboard property false by default and it looks like it is not compatible with Google Raster base maps. For our use cases, I think that this property is not necessary because is relative to the 3D rendering and the extrusion. More details here

This PR set the billboard property to false and add a test to check this property. Also, increase a bit the layer line with to keep the same look when we set the billboard property to false

Type of change

  • Fix

Forked On 20 Sep 2022 at 02:49:23

VictorVelarde

IMO it's better something like: ```suggestion - Fix the Feature selection tool by setting the `EditableGeoJsonLayer` billboard property to false to be compatible with Google raster base maps ```
On 20 Sep 2022 at 02:49:23

VictorVelarde

Release 1.4.0 (#351)

Pushed On 19 Sep 2022 at 07:32:05

VictorVelarde

Release 1.4.0

Created On 19 Sep 2022 at 07:32:04

VictorVelarde

Prepare official release

Pushed On 19 Sep 2022 at 07:29:36

VictorVelarde

Bump to latest patch 1.4.0 for carto-react in peers

Pushed On 19 Sep 2022 at 05:38:26
Issue Comment

VictorVelarde

Switch to using quadbin library

Description

Shortcut: https://app.shortcut.com/cartoteam/story/255812/add-functions-to-quadbin-js-as-required-by-carto4react

To better allow developers we have extracted the quadbin logic to a new library: https://github.com/CartoDB/quadbin-js

See related PR in deck: https://github.com/visgl/deck.gl/pull/7257

Type of change

  • Refactor

Acceptance

Please describe how to validate the feature or fix

  1. Load a quadbin tileset
  2. Verify that widget calculations are working as on production

Forked On 19 Sep 2022 at 05:37:15

VictorVelarde

To be released after new alpha with https://github.com/visgl/deck.gl/pull/7257. CI will fail in the meantime, till we have a new alpha from deck.gl

Commented On 19 Sep 2022 at 05:37:15
Issue Comment

VictorVelarde

CARTO: switch to using quadbin library

Background

To better allow developers we have extracted the quadbin logic to a new library: https://github.com/CartoDB/quadbin-js

Change List

  • Replace internal functions with versions from quadbin package
  • Switch to using bigint to represent the quadbin index in memory
  • Test updates

There is a change to the internal format so that we pass around a BigInt representation rather than a hex string. Basically changing

type QuadbinTileIndex = {i: string}; 

to

type QuadbinTileIndex = {i: bigint}; 

This will help us avoid things like this:

bigIntToHex(cellToParent(hexToBigInt(i))) 

It will help performance as we won't needlessly do these conversions.

Forked On 19 Sep 2022 at 05:36:10

VictorVelarde

We have the other PR in C4R, ready to coordinate here.

Commented On 19 Sep 2022 at 05:36:10

VictorVelarde

Bump to latest patch 1.4.0 for carto-react in peers

Pushed On 19 Sep 2022 at 04:18:47

VictorVelarde

Bump to (expected) new alpha.3 with quadbin-js in deck.gl

Pushed On 19 Sep 2022 at 04:12:43

VictorVelarde

Add title in LegendWidget (#466)

  • feat(LegendWidgetUI): ✨ add title prop

  • feat(LegendWidget): ✨ add title prop

  • chore(CHANGELOG): add not released feature

  • Update CHANGELOG.md

Co-authored-by: Víctor Velarde victor.velarde@gmail.com

Pushed On 19 Sep 2022 at 04:02:38

VictorVelarde

New 1.4.0 release (#469)

Pushed On 19 Sep 2022 at 04:02:38

VictorVelarde

Merge branch 'master' into felix/quadbin-js

Pushed On 19 Sep 2022 at 04:02:38

VictorVelarde

Bump to prepare pre-release

Pushed On 19 Sep 2022 at 01:22:59

VictorVelarde

Bump dep to latest carto-react 1.4.0

Pushed On 19 Sep 2022 at 01:19:52

VictorVelarde

Bump dep to latest carto-react 1.4.0

Pushed On 19 Sep 2022 at 01:17:04

VictorVelarde

Prepare changelog

Created On 19 Sep 2022 at 01:10:00
Create Branch
VictorVelarde In CartoDB/carto-react-template Create Branchrelease-v1.4.0-alpha.0

VictorVelarde

CARTO for React. The best way to develop Location Intelligence (LI) Apps usign CARTO platform and React

On 19 Sep 2022 at 01:09:49

VictorVelarde

New 1.4.0 release (#469)

Pushed On 19 Sep 2022 at 10:42:24

VictorVelarde

New 1.4.0 release

Created On 19 Sep 2022 at 10:42:24

VictorVelarde

v1.4.0

Pushed On 19 Sep 2022 at 10:40:55
Create Branch

VictorVelarde

CARTO for React packages

On 19 Sep 2022 at 10:40:55

VictorVelarde

New 1.4.0 release

Created On 19 Sep 2022 at 10:36:26
Create Branch
VictorVelarde In CartoDB/carto-react Create Branchrelease-1.4.0

VictorVelarde

CARTO for React packages

On 19 Sep 2022 at 10:35:57

VictorVelarde

started

Started On 15 Sep 2022 at 06:18:04

VictorVelarde

Add title in LegendWidget

Description

Shortcut: https://app.shortcut.com/cartoteam/story/257017/customizable-legendwidget-title

Background Currently, the legend has always the Layers title.

Problem In some project design we could need to change this title for other.

Designers are making designs with other titles. For example, for Spanish designs: Capas or Leyenda. If we make an application in Spanish we don't have the chance to make the modification. If we make a multi-language app we don't have the possibility to change the title according to the language.

Solution Add an optional title property with 'Layers' as a default value to LegendWidget.

Type of change

  • Feature

Acceptance

Please describe how to validate the feature or fix

In your App

  1. Go to your LegendWidget usage and add title property:

The specified title should display in the toggle button of the LegendWidget. If an empty string or null value are provided, there is not title to display. The button should appear without text.

<LegendWidget
  title={'Map Legend'}
  className={classes.legend}
/> 
  1. Check the legend of your application map in the browser:

image

Merged On 14 Sep 2022 at 09:09:15

VictorVelarde

LGTM, thx for the addition @flipasg

Commented On 14 Sep 2022 at 09:09:15

VictorVelarde

Update CHANGELOG.md

Pushed On 14 Sep 2022 at 09:07:51

VictorVelarde

Add title in LegendWidget

Description

Shortcut: https://app.shortcut.com/cartoteam/story/257017/customizable-legendwidget-title

Background Currently, the legend has always the Layers title.

Problem In some project design we could need to change this title for other.

Designers are making designs with other titles. For example, for Spanish designs: Capas or Leyenda. If we make an application in Spanish we don't have the chance to make the modification. If we make a multi-language app we don't have the possibility to change the title according to the language.

Solution Add an optional title property with 'Layers' as a default value to LegendWidget.

Type of change

  • Feature

Acceptance

Please describe how to validate the feature or fix

In your App

  1. Go to your LegendWidget usage and add title property:

The specified title should display in the toggle button of the LegendWidget. If an empty string or null value are provided, there is not title to display. The button should appear without text.

<LegendWidget
  title={'Map Legend'}
  className={classes.legend}
/> 
  1. Check the legend of your application map in the browser:

image

Merged On 14 Sep 2022 at 09:07:43

VictorVelarde

Commented On 14 Sep 2022 at 09:07:43