Simek Github contribution chart
Simek Github Stats
Simek Most Used Languages

Activity

29 Sep 2022

Simek

cleanup regex

Pushed On 29 Sep 2022 at 04:45:43
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 04:28:47

Simek

```suggestion Then, add your classes to Android and/or iOS `modules` in the [module config](./module-config.mdx). Expo Autolinking will automatically link these classes as native modules in the user's project. ``` Platform order.
On 29 Sep 2022 at 04:28:47
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 04:28:48

Simek

Commented On 29 Sep 2022 at 04:28:48
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 04:26:22

Simek

```suggestion - **On Android** the native module class will be linked automatically before building, as part of the Gradle build task. - **On iOS** you need to run `pod install` to link the new class. ``` We should preferably list Android before iOS, see: *https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md#referencing-android-ios-and-web
On 29 Sep 2022 at 04:26:22
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 04:26:22

Simek

Commented On 29 Sep 2022 at 04:26:22
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 04:23:36

Simek

```suggestion The presence of the module config is enough for [Expo Autolinking](/workflow/glossary-of-terms/#expo-autolinking) to recognize it as an Expo module and automatically link your native code. ``` Skip the domain in link.
On 29 Sep 2022 at 04:23:36
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 04:23:37

Simek

Commented On 29 Sep 2022 at 04:23:37
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 04:13:43

Simek

We also should probably reorder those, so Android is before iOS.
On 29 Sep 2022 at 04:13:43
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 04:13:44

Simek

Commented On 29 Sep 2022 at 04:13:44
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 04:12:39

Simek

```suggestion The presence of the module config is enough for Expo Autolinking](/workflow/glossary-of-terms/#expo-autolinking) to recognize it as an Expo module and automatically link your native code. ``` Good idea! Just remember to skip the domain in link.
On 29 Sep 2022 at 04:12:39
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 04:12:40

Simek

Commented On 29 Sep 2022 at 04:12:40
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 03:52:49

Simek

Thank you for working on those updates, LGTM! 🙏

Commented On 29 Sep 2022 at 03:52:49
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 02:46:42

Simek

```suggestion To create a new Expo module from scratch, just run `yarn create expo-module` or `npm create expo-module`. ``` It would be nice to add `Terminal` here, but then probably we should leave only one command. Maybe we should recommend `npx create-expo-module` then?
On 29 Sep 2022 at 02:46:42
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 02:46:43

Simek

Commented On 29 Sep 2022 at 02:46:43
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 02:44:08

Simek

```suggestion Create the [module config](module-config) **expo-module.config.json** file just near your **package.json** and start from the empty object `{}` in there. We will fill it in later to enable specific features. ``` Empty line in MD should replace the `<br/>` if I understand the use case correcctly.
On 29 Sep 2022 at 02:44:08
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 02:44:09

Simek

Commented On 29 Sep 2022 at 02:44:09
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Forked On 29 Sep 2022 at 02:26:11

Simek

As discussed, we will update the `CodeBlocksTable` and it's usages after the series of PR for Expo Modules will land. 🙂
On 29 Sep 2022 at 02:26:11
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

Closes ENG-6349

How

  • Separated Get Started from Overview and Module API
  • Moved design considerations to Overview
  • Added a section about the new architecture

Merged On 29 Sep 2022 at 02:26:12

Simek

Commented On 29 Sep 2022 at 02:26:12
Issue Comment

Simek

[eas-json] improve errors and error message formatting

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

This small PR focuses on improving custom errors emitted by eas-json, the main goal was to improve the readability.

How

Set the error name to the constructor name, decorate base error and few of the messages using chalk.

Test Plan

The changes have been tested by running locally build eas.

Preview

Forked On 29 Sep 2022 at 12:16:31

Simek

/changelog-entry chore Improve errors and error messages formatting related to eas.json.

Commented On 29 Sep 2022 at 12:16:31

Simek

add separate error for empty file + test

Pushed On 29 Sep 2022 at 12:08:15

Simek

text decoration is suppressed on CI?

Pushed On 29 Sep 2022 at 11:48:04

Simek

win happy, macos happy, will linux be too?

Pushed On 29 Sep 2022 at 11:13:18
Merge
Simek Wants To Merge expo/expo

Simek

[docs] Re-organize overview, getting started and native module API

Why

How

Test Plan

Forked On 29 Sep 2022 at 11:01:58

Simek

```suggestion ```json expo-module.config.json ``` Just FYI, this currently is a valid notation when you would like to add title to the code block. There should be no need to use `CodeBlocksTable`, unless you want to compart two files side by side.
On 29 Sep 2022 at 11:01:58
Merge

Simek

[docs] Re-organize overview, getting started and native module API

Why

How

Test Plan

Merged On 29 Sep 2022 at 11:01:59

Simek

Commented On 29 Sep 2022 at 11:01:59

Simek

an attempt to make Unix happy with regexp

Pushed On 29 Sep 2022 at 10:56:40
Merge
Simek Wants To Merge expo/eas-cli

Simek

[eas-json] improve errors and error message formatting

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

This small PR focuses on improving custom errors emitted by eas-json, the main goal was to improve the readability.

How

Set the error name to the constructor name, decorate base error and few of the messages using chalk.

Test Plan

The changes have been tested by running locally build eas.

Preview

Forked On 29 Sep 2022 at 10:53:50

Simek

<img width="347" alt="Screenshot 2022-09-29 125153" src="https://user-images.githubusercontent.com/719641/193012947-e24959a2-5c5c-43ce-a173-dd8979ec0767.png"> Maybe we can separate this edge case, I will look at it.
On 29 Sep 2022 at 10:53:50
Merge

Simek

[eas-json] improve errors and error message formatting

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

This small PR focuses on improving custom errors emitted by eas-json, the main goal was to improve the readability.

How

Set the error name to the constructor name, decorate base error and few of the messages using chalk.

Test Plan

The changes have been tested by running locally build eas.

Preview

Merged On 29 Sep 2022 at 10:53:50

Simek

Commented On 29 Sep 2022 at 10:53:50

Simek

fix few tests

Pushed On 29 Sep 2022 at 10:37:47
Pull Request

Simek

[eas-json] improve errors and error message formatting

Created On 29 Sep 2022 at 09:50:16

Simek

fix type check

Pushed On 29 Sep 2022 at 09:46:59