Platonn Github contribution chart
Platonn Github Stats
Platonn Most Used Languages

Activity

30 Sep 2022

Merge

Platonn

fix(core): update `isDevMode` to rely on `ngDevMode`

This commits update isDevMode to rely on the ngDevMode which in the CLI is set by the bundler.

We also update @angular/platform-dynamic-browser and @angular/compiler to remove usage of jitDevMode, which was the last internal usages of isDevMode.

Forked On 29 Sep 2022 at 10:05:07

Platonn

Hi @alan-agius4. I have a question, so to better understand: Now `isDevMode()` explicitly depends on `ngDevMode`. Does it by any chance help to tree-shake code in custom applications, that is conditionally wrapped with `isDevMode`()? e.g. ```ts if(isDevMode()){ console.error('Some very long string message in custom app....'); } ``` If not, would it help to expose `ngDevMode` in Angular public API, so it could be used it in custom applications? ```ts if(ngDevMode){ console.error('Some very long string message in custom app....'); } ```
On 29 Sep 2022 at 10:05:07

Platonn

fix(core): update `isDevMode` to rely on `ngDevMode`

This commits update isDevMode to rely on the ngDevMode which in the CLI is set by the bundler.

We also update @angular/platform-dynamic-browser and @angular/compiler to remove usage of jitDevMode, which was the last internal usages of isDevMode.

Merged On 29 Sep 2022 at 10:05:08

Platonn

Commented On 29 Sep 2022 at 10:05:08

Platonn

Awesome Developer Relations resources curated by the DevRel Collective

Forked On 29 Sep 2022 at 08:24:44

Platonn

remove leftover constructor dependency CartItemContextSource from cart-item.component

Pushed On 22 Sep 2022 at 02:26:05

Platonn

define outer CartItemContext and outlet in AddedToCartModal

Pushed On 22 Sep 2022 at 02:26:05

Platonn

chore(CDC): remove unnecessary 3rd param from cdcJsService.loginUserWithoutScreenSet() (#16171)

The 3rd param was a leftover from a past refactor.

sub-PR of #15785

Pushed On 16 Sep 2022 at 02:58:43
Pull Request

Platonn

chore(CDC): remove unnecessary 3rd param from cdcJsService.loginUserWithoutScreenSet()

Created On 16 Sep 2022 at 02:58:42

Platonn

fix(CDC): handle error states in forms (#16168)

  • prevent submitting the login form when the form is invalid
  • enable form back, after unsuccessful login
  • enable form back, after unsuccessful forgot-password

sub-PR for #15785

Pushed On 16 Sep 2022 at 02:56:40

Platonn

test(CDC): add jasmine done() calls inside subscriptions callbacks and fix those unit tests (#16169)

sub-PR of #15785

Pushed On 16 Sep 2022 at 02:56:40

Platonn

Merge branch 'feature/CXINT-22' of github.com:SAP/spartacus into feature/CXINT-22--bug-fixes--improve-unit-tests--remove-unnecessary-param

Pushed On 16 Sep 2022 at 02:56:40

Platonn

test(CDC): add jasmine done() calls inside subscriptions callbacks and fix those unit tests (#16169)

sub-PR of #15785

Pushed On 16 Sep 2022 at 02:49:09
Pull Request

Platonn

test(CDC): add jasmine done() calls inside subscriptions callbacks and fix those unit tests

Created On 16 Sep 2022 at 02:49:08

Platonn

fix(CDC): handle error states in forms (#16168)

  • prevent submitting the login form when the form is invalid
  • enable form back, after unsuccessful login
  • enable form back, after unsuccessful forgot-password

sub-PR for #15785

Pushed On 16 Sep 2022 at 02:47:23
Pull Request

Platonn

fix(CDC): handle error states in forms

Created On 16 Sep 2022 at 02:47:22
Pull Request

Platonn

chore(CDC): remove unnecessary 3rd param from cdcJsService.loginUserWithoutScreenSet()

Created On 16 Sep 2022 at 02:10:53

Platonn

remove unnecessary param from cdcJsService.loginUserWithoutScreenSet()

Pushed On 16 Sep 2022 at 02:09:24
Create Branch
Platonn In SAP/spartacus Create Branchfeature/CXINT-22--bug-fixes--improve-unit-tests--remove-unnecessary-param

Platonn

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

On 16 Sep 2022 at 02:07:10
Merge

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Forked On 16 Sep 2022 at 01:25:01

Platonn

fixed in https://github.com/SAP/spartacus/pull/16160
On 16 Sep 2022 at 01:25:01

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Merged On 16 Sep 2022 at 01:25:02

Platonn

Commented On 16 Sep 2022 at 01:25:02
Merge

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Forked On 16 Sep 2022 at 01:24:45

Platonn

fixed in https://github.com/SAP/spartacus/pull/16160
On 16 Sep 2022 at 01:24:45

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Merged On 16 Sep 2022 at 01:24:46

Platonn

Commented On 16 Sep 2022 at 01:24:46
Merge

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Forked On 16 Sep 2022 at 01:24:35

Platonn

Will be handled in https://github.com/SAP/spartacus/pull/16169
On 16 Sep 2022 at 01:24:35

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Merged On 16 Sep 2022 at 01:24:35

Platonn

Commented On 16 Sep 2022 at 01:24:35
Pull Request

Platonn

test(CDC register/login/forg.pass.): add jasmine done() calls inside subscriptions callbacks and fix those unit tests

Created On 16 Sep 2022 at 01:21:26
Create Branch
Platonn In SAP/spartacus Create Branchfeature/CXINT-22--bug-fixes--improve-unit-tests

Platonn

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

On 16 Sep 2022 at 01:20:05
Merge

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Forked On 16 Sep 2022 at 12:52:38

Platonn

- regarding [MINOR] - issue fixed in https://github.com/SAP/spartacus/pull/16160 - regarding [QUESTION] - we're not using super.onSuccess/onError, because we don't want to trigger the global message here (as it's already triggered from the CDC JS Service)
On 16 Sep 2022 at 12:52:38

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Merged On 16 Sep 2022 at 12:52:39

Platonn

Commented On 16 Sep 2022 at 12:52:39
Merge

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Forked On 16 Sep 2022 at 12:51:01

Platonn

simplified and fixed in https://github.com/SAP/spartacus/pull/16160
On 16 Sep 2022 at 12:51:01

Platonn

feature/CXINT-22 CDC-COMM:SPA UI - Headless Commerce: Login & Registration

Requirement Details:

https://wiki.wdf.sap.corp/wiki/display/GIGYA/SAP+Commerce+Cloud+-+Built-in+Extension

Login & Registration:

The current built-in extension allows the registration and login flows to be performed without the use of the screensets. Instead, the WebSDK functions - such as gigya.accounts.login or gigya.accounts.register - can be used, as per below recording.

Merged On 16 Sep 2022 at 12:51:01

Platonn

Commented On 16 Sep 2022 at 12:51:01