Methuselah96 Github contribution chart
Methuselah96 Github Stats
Methuselah96 Most Used Languages

Activity

05 Oct 2022

Issue Comment

Methuselah96

Uncaught TypeError: dispatcher.useInsertionEffect is not a function

Hi, after update react to version 18 react select throw following error:

Uncaught TypeError: dispatcher.useInsertionEffect is not a function 

Are you planning to update this package for react 18? Thanks in advance

Forked On 05 Oct 2022 at 01:16:01

Methuselah96

This package should with React 18. Can you check out https://github.com/JedWatson/react-select/issues/5076 and see if anything there helps resolve your issue?

Commented On 05 Oct 2022 at 01:16:01
Issue Comment

Methuselah96

add aria-required attribute to select

Description

if aria-required is passed to the select component, it is not drilled to the input element. This update adds it to the props of Select component

This

<Select
    options={options}
    aria-required={true}
  /> 

will result in

<input aria-required="true  ... /> 

For issue : #5006

Forked On 05 Oct 2022 at 12:56:53

Methuselah96

@Rall3n Any objections?

Commented On 05 Oct 2022 at 12:56:53

Methuselah96

Fix link to paragraph 1.3

A straight-forward change: the link to paragraph 1.3 ("Use @redux-devtools/extension package from npm") within the same document was not working. This fixes it.

Merged On 05 Oct 2022 at 12:53:38

Methuselah96

Thanks!

Commented On 05 Oct 2022 at 12:53:38

Methuselah96

Update link for base16 (#1231)

Pushed On 21 Sep 2022 at 02:13:37

Methuselah96

Update link for base16

Created On 21 Sep 2022 at 02:13:35
Issue Comment

Methuselah96

[pickers] Fix usage with Typescript 4.8

Fixes #6134

  • [x] Use @ts-expect-error to be aware if the error goes away in the future
  • [x] Change the file extension to .d.ts to avoid having the @ts-expect-error comment removed during the build

Forked On 21 Sep 2022 at 02:02:23

Methuselah96

Works for me as well, thanks @flaviendelangle!

Commented On 21 Sep 2022 at 02:02:23
Issue Comment

Methuselah96

Your npm page contains a link to CRYPTO CASINOS

On react-json-tree page there is a link that leads to crypto gambling:

Forked On 21 Sep 2022 at 01:57:43

Methuselah96

Thanks for the heads-up, should be resolved by https://github.com/reduxjs/redux-devtools/pull/1231.

Commented On 21 Sep 2022 at 01:57:43

Methuselah96

Update link for base16

Created On 21 Sep 2022 at 01:57:17
Create Branch
Methuselah96 In reduxjs/redux-devtools Create BranchMethuselah96-patch-1

Methuselah96

DevTools for Redux with hot reloading, action replay, and customizable UI

On 21 Sep 2022 at 01:56:38
Issue Comment

Methuselah96

[pickers] Declaration files don't type-check with TypeScript 4.8

Duplicates

  • [X] I have searched the existing issues

Latest version

  • [X] I have tested the latest version

Current behavior 😯

The declaration files currently have a error with TypeScript 4.8:

ERROR in node_modules/@mui/x-date-pickers/internals/models/muiPickersAdapter.d.ts:2:55
TS2344: Type 'TDate' does not satisfy the constraint 'ExtendableDateType'.
    1 | import { IUtils } from '@date-io/core/IUtils';
  > 2 | export declare type MuiPickersAdapter<TDate> = IUtils<TDate>;
      |                                                       ^^^^^
    3 | export declare type MuiDateSectionName = 'day' | 'month' | 'year' | 'hour' | 'minute' | 'second' | 'am-pm';
    4 | export declare type MuiFormatTokenMap = {
    5 |     [formatToken: string]: MuiDateSectionName; 

Expected behavior 🤔

The declaration files should not have an error with TypeScript 4.8.

Steps to reproduce 🕹

Create TypeScript 4.8 project with @mui/x-date-pickers with skipLibCheck turned off.

Context 🔦

I noticed this was addressed in https://github.com/mui/mui-x/pull/5935, but wanted to make sure that the fix made it into v5 since the release notes for the latest v5 release mentioned that this was the last scheduled regular release for v5.

Your environment 🌎

N/A

Order ID 💳 (optional)

No response

Forked On 20 Sep 2022 at 05:12:31

Methuselah96

@flaviendelangle The fix does not work because ts-ignore comments don't get copied to declaration files, so the original TypeScript source code will type-check, but the built declaration files will not.

Maybe we should re-open this issue until it gets resolved?

Commented On 20 Sep 2022 at 05:12:31

Methuselah96

Use chart.js

Pushed On 20 Sep 2022 at 01:55:11

Methuselah96

Finish beta using react-charts

Pushed On 20 Sep 2022 at 12:52:50

Methuselah96

Update

Pushed On 19 Sep 2022 at 08:14:45

Methuselah96

Use Yarn

Pushed On 19 Sep 2022 at 07:41:08
Create Branch

Methuselah96

Description not entered by the user.

On 19 Sep 2022 at 07:39:52
Create Branch

Methuselah96

Description not entered by the user.

On 19 Sep 2022 at 07:38:13
Issue Comment

Methuselah96

[core] Update to typescript 4.8.3 (target master)

Equivalent of #5935 but for v5

Forked On 19 Sep 2022 at 06:32:12

Methuselah96

@flaviendelangle Here is a repo with the error: https://github.com/Methuselah96/mui-x-type-issue. The key is setting skipLibCheck to false. Let me know if there's anything I can do to help move this along. I looked into extending from ExtendableDateType everywhere the TDate generic is used, but the changes seemed quite extensive, so I figured I check here first.

Commented On 19 Sep 2022 at 06:32:12
Create Branch

Methuselah96

Description not entered by the user.

On 19 Sep 2022 at 06:28:53
Create Branch

Methuselah96

Description not entered by the user.

On 19 Sep 2022 at 06:28:04
Issue Comment

Methuselah96

[core] Update to typescript 4.8.3 (target master)

Equivalent of #5935 but for v5

Forked On 19 Sep 2022 at 04:59:32

Methuselah96

@flaviendelangle Yes, this is still an issue. It looks like the @ts-ignore applied here does not make it to the declaration file.

Commented On 19 Sep 2022 at 04:59:32

Methuselah96

[docs] Improve getting-started page (#5293)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DataGrid][l10n] Improve Slovak (sk-SK) locale (#5332)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DataGridPro] Add option to infer detail panel height from content (#5163)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DateRangePicker] Fix keyboard selection (#5265)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DayPicker] Remove empty space at the bottom of the day view (#5073)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DataGrid] Mention Premium plan in error messages and docs warnings (#5328)

  • mention DataGridPremium in error messages

  • mention Premium plan in docs warnings

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[l10n] Add Romanian (ro-RO) locale (#5345)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[docs] Fix server-side pagination demo (#5361)

fix server-side pagination demo

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DataGridPro] Fix the depth of nodes when switching from a non-flat tree to a flat tree (#5362)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[docs] Use useKeepGroupedColumnsHiddren from the grid package on remaining demo (#5382)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[pickers] Add missing type dependencies (#5331)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[docs] Explain how to use hooks inside a cell renderer (#5158)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[date picker] add pass by of base theme to the components theme augme… (#5199)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DataGrid] Fix "stop editing" integration with IME e.g. Japanese (#5257)

Co-authored-by: Matheus Wichman matheushw@outlook.com

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

[DataGrid] Fix dimensions computation with autoHeight and scroll x (#5401)

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

Bump @types/node to ^18.0.3 (#5324)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

Bump @mui/styles to ^5.8.7 (#5178)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

Bump eslint to ^8.19.0 (#5378)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

Bump @visx/xychart to ^2.11.1 (#5376)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

Bump @docsearch/react to ^3.1.1 (#5374)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 04:36:34

Methuselah96

v5.10.6 (#34381)

Pushed On 19 Sep 2022 at 02:39:45

Methuselah96

[lab][deps] Move @mui/types to dependencies

Pushed On 19 Sep 2022 at 02:39:45

Methuselah96

v5.10.6 (#34381)

Pushed On 19 Sep 2022 at 02:38:09

Methuselah96

[lab][deps] Move @mui/types to dependencies

Created On 19 Sep 2022 at 02:36:41
Create Branch
Methuselah96 In Methuselah96/material-ui Create Branchmove-mui-types-to-deps

Methuselah96

React components that implement Google's Material Design.

On 19 Sep 2022 at 02:35:50

Methuselah96

[release] v5.8.6 (#33305)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[BadgeUnstyled] Export BadgeUnstyledOwnProps interface to fix typescript compiler error (#33314)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[Joy] Add switch documentation (#33302)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[docs] Fix Slider's "player" demo (#33267)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[Autocomplete] Extend componentsProps to include popper and popupIndicator slots (#33283)

[Autocomplete] Extend componentsProps to include popper and popupIndicator slots (#33233, #33234)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[Joy] Add radio button documentation (#33254)

Co-authored-by: danilo leal 67129314+danilo-leal@users.noreply.github.com

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[styled-engine] Add missing type dependency on csstype (#33310)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump marked to ^4.0.17 (#33294)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump react-docgen to ^5.4.2 (#33295)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump recharts to ^2.1.12 (#33296)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump theme-ui to ^0.14.6 (#33297)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump @testing-library/dom to ^8.14.0 (#33298)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump Emotion (#33299)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump aws-sdk to ^2.1166.0 (#33300)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump @types/react-transition-group to ^4.4.5 (#33293)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump eslint to ^8.18.0 (#33301)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[Autocomplete] Add some missing props in useAutocomplete (#33269)

Co-authored-by: Marija Najdova mnajdova@gmail.com Co-authored-by: Michał Dudak michal@dudak.me

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Bump react-intersection-observer to ^9.3.5 (#33119)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[Select] Annotate empty string as valid value prop (#33088)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

[system] Export required types (#33324)

Pushed On 19 Sep 2022 at 02:19:59

Methuselah96

Add missing types dependency

Initial checklist

  • [x] I read the support docs
  • [x] I read the contributing guide
  • [x] I agree to follow the code of conduct
  • [x] I searched issues and couldn’t find anything (or linked relevant results below)
  • [x] If applicable, I’ve added docs and tests

Description of changes

This PR moves @types/mdast back to dependencies since the declaration files still reference them. This was initially done in https://github.com/syntax-tree/mdast-util-gfm-table/pull/2, but then moved to a devDependency in https://github.com/syntax-tree/mdast-util-gfm-table/commit/c7c917851937251be18e5ddb547b49625fdad408. @types/mdast still needs to be listed as a dependency since @types/mdast is still referenced in the generated lib/index.d.ts file.

Forked On 13 Sep 2022 at 12:58:54

Methuselah96

Sure, everything’s been discussed at length. You should be able to find threads on this.

Do you have any links handy? I'm not sure what repo to look in.

Commented On 13 Sep 2022 at 12:58:54