MatinF Github contribution chart
MatinF Github Stats
MatinF Most Used Languages

Activity

03 Dec 2022

Issue Comment

MatinF

How to decode data in a specific format

Hi, I am using the dbc file from CSS electronics to decode CAN Data. I have CAN data as following format: CF00400#FFFFFFC080FFFFFF

first part is CAN Id (or frame id) : CF00400 second part (CAN data) : FFFFFFC080FFFFFF

How do I decode this CAN data using the can_decoder? df_decoder.decode_frame(df_raw, columns_to_drop=["CAN ID", "Raw Value"]) How do I construct the df_raw based on above CAN data?

Forked On 01 Dec 2022 at 06:20:51

MatinF

Hi there, I suggest seeing our api-examples where you can test this with the J1939 sample data: api-examples/examples at master ยท CSS-Electronics/api-examples

Commented On 01 Dec 2022 at 06:20:51

MatinF

Minor updates

Pushed On 29 Nov 2022 at 07:05:54

MatinF

Misc updates

Pushed On 25 Nov 2022 at 07:39:52
Issue Comment

MatinF

Geomap: Epic

Epic to capture and prioritize improvements for Geomap, including bug fixes and new features.

https://github.com/grafana/grafana/issues/58543#tasklist-block-f7b546a5-c1b3-4e2b-b896-912d07725b2f

https://github.com/grafana/grafana/issues/58543#tasklist-block-75cef8ae-32d6-4ac1-a7e1-1d330474a8bc

https://github.com/grafana/grafana/issues/58543#tasklist-block-e616763e-3248-40d2-8ca4-d371355460c6

Forked On 23 Nov 2022 at 07:48:31

MatinF

Thanks - is there an ETA on when this is expected to enter into the Grafana cloud as an option?

Commented On 23 Nov 2022 at 07:48:31
Issue Comment

MatinF

Feature: Save display file with multiple windows

The ability to save a display configuration is very useful for quickly opening up previous analyses/views.

However, it would be great if it would be possible to not only store 1 plot window - but that the display configuration stores the full 'grid' of plot windows with the correct sizing, focus area, plot coloring, zoom level (for GNSS plots) etc. This would enable almost a 'dashboard' style view in asammdf with minimal effort.

Forked On 18 Nov 2022 at 01:53:41

MatinF

Hi Daniel,

I tested in latest dev. here is my plot view:

image

When I save this as a display config, close the plots and open the display config, I do indeed get multiple windows now - but the focus seems off. It would be OK with the focus not being saved, but it would be nice if then at least the 'default' focus is selected when the display is loaded, so that the entire plots are displayed:

image

Commented On 18 Nov 2022 at 01:53:41
Issue Comment

MatinF

Geomap: Epic

Epic to capture and prioritize improvements for Geomap, including bug fixes and new features.

https://github.com/grafana/grafana/issues/58543#tasklist-block-f7b546a5-c1b3-4e2b-b896-912d07725b2f

https://github.com/grafana/grafana/issues/58543#tasklist-block-75cef8ae-32d6-4ac1-a7e1-1d330474a8bc

https://github.com/grafana/grafana/issues/58543#tasklist-block-e616763e-3248-40d2-8ca4-d371355460c6

Forked On 15 Nov 2022 at 07:07:43

MatinF

Will this epic incorporate the trackmap style routes + timesynced crosshair support from below? https://github.com/grafana/grafana/pull/43554

Commented On 15 Nov 2022 at 07:07:43

MatinF

Remove support for additional log file format structures

Pushed On 20 Oct 2022 at 07:42:02

MatinF

Updates to enable loading of S3 uischemas

Pushed On 19 Oct 2022 at 09:55:53

MatinF

Misc edits to update behavior for UIschema in CANcloud

Pushed On 19 Oct 2022 at 09:33:45
Create Branch
MatinF In CSS-Electronics/cancloud Create Branchv05.08.01

MatinF

CANcloud - open source telematics platform

On 18 Oct 2022 at 12:14:43
Create Branch

MatinF

'Base module' for use in configuration editor tool

On 18 Oct 2022 at 12:13:52
Create Branch

MatinF

Simple configuration editor for the CANedge & modules

On 18 Oct 2022 at 12:13:30

MatinF

Updated imported config-editor-base module and config-editor-tools

Pushed On 18 Oct 2022 at 12:09:18

MatinF

Misc updates to CSS styling

Pushed On 18 Oct 2022 at 12:08:39

MatinF

Misc CSS edits and updates to imported packages

Pushed On 18 Oct 2022 at 11:33:24

MatinF

Hide Uischema info modal onClick and fix ArrayFieldTemplate

Pushed On 18 Oct 2022 at 11:32:03

MatinF

Dependency updates

Pushed On 18 Oct 2022 at 08:54:12

MatinF

Multiple pages proposal

Prerequisites

Description

It would be nice to have multiple pages in a form. As a first pass, I'm proposing something like the following in the uiSchema:

{
    "ui:options": {
        "pages": [
            {
                "title": "Page 1",
                "ui:order": [
                    "name",
                    "address",
                    "email"
                ]
            },
            {
                "title": "Page 2",
                "ui:order": [
                    "zipcode",
                    "abc"
                ]
            }
        ]
    }
} 

This would put everything in all pages within a single schema. In the case we have an array of required elements, then, perhaps validation errors could show only at the end once all pages are completed.

Not sure if this is the right way to do it; would appreciate some feedback!

Forked On 18 Oct 2022 at 08:51:50

MatinF

We created a version of the react-jsonschema-form-pagination project that includes just the tabs functionality and which works with the latest rjsf versions. You can find it here: https://github.com/CSS-Electronics/rjsf-tabs

It would be ideal to modify this so as to better integrate with rjsf through e.g. the plugins functionality, or perhaps an integration into the core project. But we are not sure what that would require in terms of code modification. However, we're hoping our updated project may help others and may serve as the basis for a more formal integration.

Commented On 18 Oct 2022 at 08:51:50

MatinF

Updated to use latest react-jsonschema-form version and external rjsf-tabs package

Pushed On 18 Oct 2022 at 08:31:57

MatinF

Initial commit

Pushed On 18 Oct 2022 at 08:26:02
Create Branch

MatinF

Tab structure for react-jsonschema-form

On 18 Oct 2022 at 08:11:05
Create Branch

MatinF

Tab structure for react-jsonschema-form

On 18 Oct 2022 at 08:11:05
Issue Comment

MatinF

Bus Logging: #IDs matched vs. total is incorrect for J1939

The Bus Logging print output displays the total number of CAN IDs in the log file, as well as how many of these were 'decodable' using a set of DBC files. However, when converting data using a J1939 DBC file, the numbers are misleading.

Example: An MF4 may contain 300 unique CAN IDs, but only 100 unique PGNs.

  • In this case, a DBC file may match 10 unique PGNs, corresponding to 30 unique CAN IDs
  • The console output will display this as if the DBC decodes 30 of 100 IDs (30%)

In the above example, we are comparing "CAN IDs" vs. "PGNs", resulting in an incorrect comparison.

A better approach would be to either:

  1. Always display these numbers as CAN IDs (in the above case it would then show 30 of 300 IDs)
  2. Always display these numbers as PGNs if J1939 (in the above case it would then show 10 of 100 IDs)

I think the error has arisen since the removal of 'bundling' IDs by PGN for J1939, which has resulted in all PGNs being separated by their SA. This is OK for the final output, but it currently results in an incorrect print output.

Hope clear, Martin

Forked On 10 Oct 2022 at 12:28:08

MatinF

Nevermind, it looks like I misread the data - it appears that the values are based on the total number of unique PGNs taking the SA into account as well, so I believe it is consistent.

Commented On 10 Oct 2022 at 12:28:08