Crash-- Github contribution chart
Crash-- Github Stats
Crash-- Most Used Languages

Activity

05 Oct 2022

Crash--

feat: Add About button to redirect to store page
Merged On 05 Oct 2022 at 02:13:14

Crash--

Commented On 05 Oct 2022 at 02:13:14
Merge

Crash--

feat: Add About button to redirect to store page
Forked On 05 Oct 2022 at 02:13:13

Crash--

OK, en fait on mock le composant https://github.com/cozy/cozy-settings/blob/94802a4b197bc1428b0433d04491da5deedb2f0a/src/components/Permissions/AppPermissions.spec.jsx#L68-L70 et c'est là qu'on retourne le data-testid. C'est une pratique que je pige pas trop parce que justement ce qui nous intéresse nous c'est de savoir que le label est bien affiché à l'utilisateur. Et donc moi je dégagerai ce mock et je ferais 2 getByText pour m'assurer que les trucs soient bien visibles pour l'utilisateur
On 05 Oct 2022 at 02:13:13
Merge

Crash--

feat: Add About button to redirect to store page
Forked On 05 Oct 2022 at 02:09:33

Crash--

J'imagine que là, tu as une erreur dans le test qui te dit un truc du genre : ``` Found multiple elements by: [data-testid= ``` Et c'est assez normal, le testid devrait être unique (et c'est pour ça que je cherche d'où vient ce souci)
On 05 Oct 2022 at 02:09:33

Crash--

feat: Add About button to redirect to store page
Merged On 05 Oct 2022 at 02:09:33

Crash--

Commented On 05 Oct 2022 at 02:09:33

Crash--

feat: Add About button to redirect to store page
Merged On 05 Oct 2022 at 02:07:19

Crash--

Commented On 05 Oct 2022 at 02:07:19
Merge

Crash--

feat: Add About button to redirect to store page
Forked On 05 Oct 2022 at 02:07:18

Crash--

Ah bah si, le test existant testait si y avait un 'CircleButton' qui était là. Le CircleButton étant généré par https://github.com/cozy/cozy-settings/blob/master/src/components/Permissions/OpenappButton.jsx#L35 Le `AboutButton` fait planter le test, car lui aussi il ajoute un `CircleButton`. D'ailleurs je me demande comment le premier test pouvait fonctionner ? Car le `queryByTestId` regarde si on a un `data-testid` dans le DOM généré. Si je regarde le code de OpenApp, je vois pas de data-testid avec `CircleButton`dedans https://github.com/cozy/cozy-settings/blob/master/src/components/Permissions/OpenappButton.jsx#L35-L41 Donc je me suis dit que c'était UI qui mettait ça tout seul. Donc je suis allé voir le component `CircleButton` https://github.com/cozy/cozy-ui/blob/master/react/CircleButton/index.jsx et là je trouve rien non plus concernant ce data-testid. Par quelle magie ça pouvait bien fonctionner ? Qu'est-ce que j'ai loupé ? Pour moi, au lieu de tester `CircleButton` tu devrais tester si tu as bien le label qui est affiché https://github.com/cozy/cozy-settings/blob/master/src/components/Permissions/OpenappButton.jsx#L36 et maintenant si tu as bien le 2e label d'affiché https://github.com/cozy/cozy-settings/pull/493/files#diff-2ab6a84c14090600193b8b8a4afdd588e49fd9687e4a51b1a4c122d9319a16c4R27 Donc le test est à remettre mais à ré-écrire un petit peu
On 05 Oct 2022 at 02:07:18
Merge

Crash--

feat: Add CircularChart component

demo : https://jf-cozy.github.io/cozy-ui/react/#!/CircularChart

Forked On 05 Oct 2022 at 10:11:20

Crash--

J'allais dire quid de CircularProgress, mais cool de le réutiliser !
On 05 Oct 2022 at 10:11:20

Crash--

feat: Add CircularChart component

demo : https://jf-cozy.github.io/cozy-ui/react/#!/CircularChart

Merged On 05 Oct 2022 at 10:11:21

Crash--

Commented On 05 Oct 2022 at 10:11:21

Crash--

fix: Add permissions to Photos

Cozy-ui's viewer needs to be able to query konnectors and triggers in order to display the konnector block with the status of the konnector and the icone.

fix: Viewer on photo display correctly the information about the konnector if there is some to display. 

Merged On 05 Oct 2022 at 08:08:15

Crash--

Commented On 05 Oct 2022 at 08:08:15
Merge

Crash--

fix: Add permissions to Photos

Cozy-ui's viewer needs to be able to query konnectors and triggers in order to display the konnector block with the status of the konnector and the icone.

fix: Viewer on photo display correctly the information about the konnector if there is some to display. 

Forked On 05 Oct 2022 at 08:08:14

Crash--

Oui. Je veux le GET sur tous les triggers. Et je veux le POST que sur un sous ensemble.
On 05 Oct 2022 at 08:08:14

Crash--

fix: Add permissions to Photos

Cozy-ui's viewer needs to be able to query konnectors and triggers in order to display the konnector block with the status of the konnector and the icone.

Pushed On 05 Oct 2022 at 07:46:40

Crash--

fix: Add permissions to Photos

Created On 05 Oct 2022 at 07:46:39
Merge

Crash--

fix: Add permissions to Photos

Cozy-ui's viewer needs to be able to query konnectors and triggers in order to display the konnector block with the status of the konnector and the icone.

fix: Viewer on photo display correctly the information about the konnector if there is some to display. 

Forked On 05 Oct 2022 at 07:34:44

Crash--

car ça existe déjà https://github.com/cozy/cozy-drive/blob/2f488edf3079435c7ca9369a3c154537d9e0ff04/src/photos/targets/manifest.webapp#L106
On 05 Oct 2022 at 07:34:44

Crash--

fix: Add permissions to Photos

Cozy-ui's viewer needs to be able to query konnectors and triggers in order to display the konnector block with the status of the konnector and the icone.

fix: Viewer on photo display correctly the information about the konnector if there is some to display. 

Merged On 05 Oct 2022 at 07:34:45

Crash--

Commented On 05 Oct 2022 at 07:34:45
Issue Comment

Crash--

Do not show placeholder lines in Recent tab when data is already there

When data is already there, we should not show placeholder lines and directly display the data.

Forked On 05 Oct 2022 at 06:59:22

Crash--

closing this issue since this is done since a few months / years now.

Commented On 05 Oct 2022 at 06:59:22
Issue Comment

Crash--

Version:drive fails on Linux

The command yarn version:drive fails on Ubuntu 19.04 with yarn 1.17.3. More precisely, the command version:drive:androidbuild is failing with :

/bin/sh: 1: Bad substitution
error Command failed with exit code 2 

Forked On 05 Oct 2022 at 06:58:29

Crash--

See https://github.com/cozy/cozy-drive/pull/2719

Commented On 05 Oct 2022 at 06:58:29
Issue Comment

Crash--

"Recent" view sometimes misses a slash in the directory path

Here the path is actually "/Factures/Netflix" not "/FactureNetflix". For some other bills the middle slash is present as expected.

screenshot_20180824-153459

Forked On 05 Oct 2022 at 06:54:28

Crash--

Should be fixed now (in fact since a few months but I didn't update the issue...)

Commented On 05 Oct 2022 at 06:54:28
Issue Comment

Crash--

Broken image on post-authentication screen

See the broken image just below the title:

screenshot_20180822-232107

BTW, I don't know why this page was in english whereas everything else was in French…

Forked On 05 Oct 2022 at 06:53:47

Crash--

Closing this issue since its pretty old.

Commented On 05 Oct 2022 at 06:53:47
Issue Comment

Crash--

Invalid Web App Manifest

I'm using the the cloud instance at mycozy.cloud and when I try to add the web app to my home screen it doesn't open in standalone display mode as specified in the manifest.

Firefox Nightly doesn't show the ambient add to home screen badge in the URL bar and adding a page shortcut fails to find an icon. Chrome finds an icon but has to automatically generate a name and doesn't open the app in standalone display mode.

I noticed that the "name" field of the web app manifest for the photos app is blank, which may be the reason.

Forked On 05 Oct 2022 at 06:52:10

Crash--

Should be fixed, closing this issue.

Commented On 05 Oct 2022 at 06:52:10
Issue Comment

Crash--

`UIWebView` deprecation

UIWebView component is deprecated since years.

And will no longer be accepted to App Store by the end of 2020.

Now, you need to use WKWebView.

Source: https://developer.apple.com/news/?id=12232019b

Forked On 05 Oct 2022 at 06:51:28

Crash--

Closing this issue since Apple still accept UIWebView for now.

Commented On 05 Oct 2022 at 06:51:28
Issue Comment

Crash--

Invalid meta data errors should not stop sync

I am using Cozy with heavily updated files (i.e. Latex documents or Zotero files). I often having an "Invalid meta data error" for these files and I am forced to click on the button "Try again" in order to have my files updated (even my other files that don't have this error). I would like my files to be synch and have some kind of automatic retry for the ones that have this meta data error.

Forked On 05 Oct 2022 at 06:49:19

Crash--

I'm closing this issue since it's related to cozy-desktop https://github.com/cozy-labs/cozy-desktop/ . Feel free to contact us if there is still an issue.

Commented On 05 Oct 2022 at 06:49:19