BlenderDude Github contribution chart
BlenderDude Github Stats
BlenderDude Most Used Languages

Activity

28 Sep 2022

BlenderDude

Math, Code, and dark spooky mode

Pushed On 28 Sep 2022 at 03:56:34

BlenderDude

Removed MDX from config, using dynamic props

Pushed On 28 Sep 2022 at 02:42:38

BlenderDude

Update AS dependencies

Upgrade to latest AS deps and incorporate breaking changes.

Merged On 27 Sep 2022 at 12:06:16

BlenderDude

Looks good!

Commented On 27 Sep 2022 at 12:06:16

BlenderDude

Upgrade jest to v29

Currently failing due to an issue with ts-jest failing to resolve the specified tsconfig in the jest configuration file.

https://github.com/kulshekhar/ts-jest/issues/3841

Merged On 27 Sep 2022 at 12:04:49

BlenderDude

Commented On 27 Sep 2022 at 12:04:49

BlenderDude

Configure changeset for this repo

TODO:

  • [x] Add an NPM_TOKEN secret to the GH action secrets for publishing to NPM.

Either / neither:

  • [ ] Enable changeset bot (optional, kinda noisy - leaves a comment on all PRs)
  • [ ] Require a changeset on PRs in CI (a bit heavy-handed but effective, empty changesets are acceptable)

Merged On 20 Sep 2022 at 01:40:19

BlenderDude

LGTM 🎊

Commented On 20 Sep 2022 at 01:40:19

BlenderDude

Configure changeset for this repo

TODO:

  • [x] Add an NPM_TOKEN secret to the GH action secrets for publishing to NPM.

Either / neither:

  • [ ] Enable changeset bot (optional, kinda noisy - leaves a comment on all PRs)
  • [ ] Require a changeset on PRs in CI (a bit heavy-handed but effective, empty changesets are acceptable)

Forked On 20 Sep 2022 at 01:40:03

BlenderDude

@michael-watson I agree let's get third merged. Even for early dev it will help keep versioning consistent.

Commented On 20 Sep 2022 at 01:40:03

BlenderDude

Add support for APIGatewayV1
Merged On 19 Sep 2022 at 08:14:09

BlenderDude

LGTM 🚀

Commented On 19 Sep 2022 at 08:14:09

BlenderDude

Add support for APIGatewayV1
Forked On 19 Sep 2022 at 08:12:58

BlenderDude

Looks good! I just wrote that in the github suggestion editor so I figured something would need changing. Your implementation looks great!
On 19 Sep 2022 at 08:12:58

BlenderDude

Add support for APIGatewayV1
Merged On 19 Sep 2022 at 08:12:58

BlenderDude

Commented On 19 Sep 2022 at 08:12:58

BlenderDude

Add support for APIGatewayV1
Forked On 19 Sep 2022 at 08:10:33

BlenderDude

Correct. Not really a difference. I agree that in this case it doesn't matter but I'll explain why I prefer repeated if's over if-else. It was a convention used at a previous place I worked, with the reasoning being that on more complex types the if-return would "pick away" from the union. We did this because it would keep consistency between the default cases. We had a lot of statements like the one above, where the default case should not be encountered at runtime and throw, but we also had cases where 2 of 4 possible types of a union would have an early return, and the remaining two would be processed by the default case. It was the difference between having that default case be indented or not, and the preference was to keep the default case as part of the main function body as opposed to the if-else body.
On 19 Sep 2022 at 08:10:33

BlenderDude

Add support for APIGatewayV1
Merged On 19 Sep 2022 at 08:10:34

BlenderDude

Commented On 19 Sep 2022 at 08:10:34

BlenderDude

Add support for APIGatewayV1
Merged On 19 Sep 2022 at 07:59:21

BlenderDude

Commented On 19 Sep 2022 at 07:59:21

BlenderDude

Add support for APIGatewayV1
Forked On 19 Sep 2022 at 07:59:20

BlenderDude

I agree that'd be better!
On 19 Sep 2022 at 07:59:20

BlenderDude

Add support for APIGatewayV1
Forked On 18 Sep 2022 at 05:51:55

BlenderDude

`else if` and `else` are redundant because the `if` will return and cancel function execution ```suggestion if (isV1Event(event)) { return normalizeV1Event(event); } if (isV2Event(event)) { return normalizeV2Event(event); } throw Error('Unknown event type'); ```
On 18 Sep 2022 at 05:51:55

BlenderDude

Add support for APIGatewayV1
Forked On 18 Sep 2022 at 06:18:36

BlenderDude

Would it be a lot cleaner and consistent to use `URLSearchParams`? ```suggestion // Single value parameters can be directly added const searchParams = new URLSearchParams(event.queryStringParameters); // Passing a key with an array entry to the constructor yields // one value in the querystring with %2C as the array was flattened to a string // Multi values must be appended individually to get the to-spec output for (const [key, values] of Object.entries(event.multiValueQueryStringParameters)) { for(const value of values) { searchParams.append(key, value); } } const searchParamString = `?${searchParams.toString()}` ```
On 18 Sep 2022 at 06:18:36

BlenderDude

Add support for APIGatewayV1
Forked On 18 Sep 2022 at 06:23:15

BlenderDude

Similar to above this could be collapsed due to the `return` short circuit. ``` if (body && contentType === 'application/json') { return JSON.parse(body); } if (body && contentType === 'text/plain') { return body; } return ''; ```
On 18 Sep 2022 at 06:23:15

BlenderDude

Add support for APIGatewayV1
Forked On 18 Sep 2022 at 06:20:15

BlenderDude

No comment here but thank you AWS for having this lol
On 18 Sep 2022 at 06:20:15

BlenderDude

Add support for APIGatewayV1
Merged On 18 Sep 2022 at 06:26:15

BlenderDude

Just a few semantic notes/questions. Overall looks good!

Commented On 18 Sep 2022 at 06:26:15

BlenderDude

Add support for APIGatewayV1
Merged On 18 Sep 2022 at 06:26:15

BlenderDude

Just a few semantic notes/questions. Overall looks good!

Commented On 18 Sep 2022 at 06:26:15

BlenderDude

Allow changeset to write to the pull request API

Pushed On 08 Sep 2022 at 04:16:41

BlenderDude

Merge pull request #214 from apollographql/da/fix-changeset-permissions

Allow changeset to write to the pull request API

Pushed On 08 Sep 2022 at 04:16:41

BlenderDude

Allow changeset to write to the pull request API

Created On 08 Sep 2022 at 04:16:41

BlenderDude

Allow changeset to write to the pull request API

Created On 08 Sep 2022 at 02:25:00
Create Branch
BlenderDude In apollographql/docs Create Branchda/fix-changeset-permissions

BlenderDude

📚 Apollo's docs framework

On 08 Sep 2022 at 02:22:44

BlenderDude

Updated remark parsing and added extra code block props

Updated typescript remark parser to fix pattern matching issue found in some imports for TS code blocks. See below (yes there are import statements at the end of a couple hundred comment tokens 😄 )

This update also introduces additional props to the CodeBlock component and implements a fallback to "local" tabs if the global context is not available. Useful for things other than the docs!

Forked On 07 Sep 2022 at 09:45:47

BlenderDude

I did my best to follow the guidelines laid out here (https://www.w3.org/WAI/ARIA/apg/example-index/tabs/tabs-manual.html). So hitting tab should be able to move between tabs, but one thing I did not consider is the highlighted element might end up "out of view" because of the scrolling. Definitely something we should look into and discuss!
On 07 Sep 2022 at 09:45:47

BlenderDude

Updated remark parsing and added extra code block props

Updated typescript remark parser to fix pattern matching issue found in some imports for TS code blocks. See below (yes there are import statements at the end of a couple hundred comment tokens 😄 )

This update also introduces additional props to the CodeBlock component and implements a fallback to "local" tabs if the global context is not available. Useful for things other than the docs!

Merged On 07 Sep 2022 at 09:45:47

BlenderDude

Commented On 07 Sep 2022 at 09:45:47

BlenderDude

Updated remark parsing and added extra code block props

Pushed On 07 Sep 2022 at 07:18:06

BlenderDude

Changeset

Pushed On 07 Sep 2022 at 07:18:06

BlenderDude

Merge pull request #210 from apollographql/da/fix-remark-ts-parse

Pushed On 07 Sep 2022 at 07:18:06

BlenderDude

Updated remark parsing and added extra code block props

Created On 07 Sep 2022 at 07:18:06

BlenderDude

docs: Update "Using Apollo with TypeScript" with a description of fetchMore and subscribeToMore

Resolves #9946.

This is my first contribution to apollo-client so feedback is welcome!

Checklist:

  • [x] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • [ ] ~Make sure all of the significant new logic is covered by tests~

Merged On 02 Sep 2022 at 03:43:08

BlenderDude

Commented On 02 Sep 2022 at 03:43:08

BlenderDude

Updated remark parsing and added extra code block props

Created On 01 Sep 2022 at 09:26:15

BlenderDude

Changeset

Pushed On 01 Sep 2022 at 09:26:12