BenLorantfy Github contribution chart
BenLorantfy Github Stats
BenLorantfy Most Used Languages

Activity

18 Sep 2022

BenLorantfy

Add shared libraries article

Pushed On 18 Sep 2022 at 05:07:09

BenLorantfy

Fix nested paragraphs inside lists

Pushed On 18 Sep 2022 at 04:43:18

BenLorantfy

v5.1.5

Pushed On 18 Sep 2022 at 04:25:40

BenLorantfy

Fix quote parser when there are newlines in quote

Pushed On 18 Sep 2022 at 04:25:40

BenLorantfy

Fix typing for `createManager` (#36)

Created On 17 Jul 2022 at 07:30:42

BenLorantfy

Fix typing for createManager (#36)

Pushed On 17 Jul 2022 at 07:30:31

BenLorantfy

Fix typing for `createManager`

Created On 17 Jul 2022 at 07:30:30

BenLorantfy

Fix typing for `createManager`
Merged On 17 Jul 2022 at 07:29:47

BenLorantfy

Looks good, thanks @mrfratello 🙂

Commented On 17 Jul 2022 at 07:29:47

BenLorantfy

Not able to get the store value

I am trying to get the initial state values from the Store directly using

const store = createStore(reducer, composeEnhancers( ... )); store.getState()

I am getting undefined

Forked On 17 Jul 2022 at 07:25:07

BenLorantfy

Hey @Aravindraj92 - I'm not quite sure I understand the question. Can you elaborate further please?

Also if you can include a sample of what your reducer looks like, that would be helpful

Commented On 17 Jul 2022 at 07:25:07

BenLorantfy

Fix typing for `createManager`
Forked On 06 Jul 2022 at 04:06:19

BenLorantfy

Do you mind also updating the documentation here: https://github.com/react-boilerplate/redux-injectors/blob/master/src/createManager.js#L4-L21 Unfortunately there's duplicate documentation. After you update that comment, you can run `npm run build:docs` and it will update the generated markdown docs
On 06 Jul 2022 at 04:06:19

BenLorantfy

Fix typing for `createManager`
Merged On 06 Jul 2022 at 04:07:18

BenLorantfy

Hey @mrfratello , thanks for the fix 🙂

Had one request before merging.

Commented On 06 Jul 2022 at 04:07:18

BenLorantfy

Fix typing for `createManager`
Merged On 06 Jul 2022 at 04:07:18

BenLorantfy

Hey @mrfratello , thanks for the fix 🙂

Had one request before merging.

Commented On 06 Jul 2022 at 04:07:18

BenLorantfy

incorrect typing for function `createManager` ?

According to the source code of createManager, we can not pass reducer and saga in the parameter options:

 const isReducerInjected = reducer // <-- check
      ? useInjectReducer({ key, reducer })
      : true;

    const isSagaInjected = saga // <-- check
      ? useInjectSaga({ key, saga }) 
      : true; 

But in typing, these properties are required:

export function createManager(options: { name: string, key: string, saga: Saga, /* <- required */ reducer: Reducer  /* <- required */  }): ...; 

What is the mistake? in typing or implementation?

Forked On 06 Jul 2022 at 04:02:07

BenLorantfy

Hey @mrfratello , this is a mistake with the typings. They should be optional. If you want to create a small PR, I'll accept it 🙂

Commented On 06 Jul 2022 at 04:02:07

BenLorantfy

Can I integrate to Next.Js?
Forked On 06 Jul 2022 at 03:58:10

BenLorantfy

Hey @cuongdevjs , I don't think this library will work well with nextjs if you use server-side rendering. Internally, it uses useLayoutEffect which does not run with server-side rendering.

If you use only client-side rendering, you should be able to follow the regular instructions here: https://github.com/react-boilerplate/redux-injectors#setting-up-the-redux-store

tbh I haven't tested it yet. If you try setting it up, let me know how it goes.

Commented On 06 Jul 2022 at 03:58:10

BenLorantfy

Add guess and pray debugging article

Pushed On 03 Jul 2022 at 03:04:25