0xmax Github contribution chart
0xmax Github Stats
0xmax Most Used Languages

Activity

29 Nov 2022

0xmax

started

Started On 29 Nov 2022 at 08:08:31
Started

0xmax

started

Started On 24 Oct 2022 at 09:03:09
Started

0xmax

started

Started On 24 Oct 2022 at 08:32:50

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds (#1583)

Pushed On 19 Oct 2022 at 08:20:10

0xmax

build(302ce425c5b3c43738036ec06ea4fa68b443bdfd): auto-commit package sizes

Pushed On 19 Oct 2022 at 08:20:10

0xmax

v2.16.0

Pushed On 19 Oct 2022 at 08:20:10

0xmax

changelog: v2.16.0

Pushed On 19 Oct 2022 at 08:20:10
Issue Comment

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds

:bug: Bug Fix

This pull request extends the withBoundingRects to use optional refs instead of findDomNode. This should solve the deprecation warning in R18 with strictMode as discussed here To check the fix please enable reactStrictMode: true in next.config.js in the demo package.

This should not introduce any breaking changes. If the res is not passed, withBoundingRects falls back to findDOMNode. I would appreaciate pointers on how to correctly type the nodeRef in TooltipWithBounds.tsx

Forked On 18 Oct 2022 at 05:41:00

0xmax

Ok, now it should work as intended.

Commented On 18 Oct 2022 at 05:41:00

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds

Pushed On 18 Oct 2022 at 05:39:33

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds

Pushed On 18 Oct 2022 at 05:38:05
Issue Comment

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds

:bug: Bug Fix

This pull request extends the withBoundingRects to use optional refs instead of findDomNode. This should solve the deprecation warning in R18 with strictMode as discussed here To check the fix please enable reactStrictMode: true in next.config.js in the demo package.

This should not introduce any breaking changes. If the res is not passed, withBoundingRects falls back to findDOMNode. I would appreaciate pointers on how to correctly type the nodeRef in TooltipWithBounds.tsx

Forked On 18 Oct 2022 at 04:49:10

0xmax

@williaster would be very happy if I can make an useful contribution to such an awsome project! Unfortunately there seems to be an issue with the initialization in withBoundingRect. I will investigate and come back to you shortly.

Commented On 18 Oct 2022 at 04:49:10

0xmax

v2.15.2

Pushed On 17 Oct 2022 at 09:37:11
Create Branch
0xmax In 0xmax/visx Create Branchv2.15.2

0xmax

🐯 visx | visualization components

On 17 Oct 2022 at 09:37:11

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds

Pushed On 17 Oct 2022 at 09:34:09

0xmax

maint: add prepare script

Pushed On 17 Oct 2022 at 09:34:09

0xmax

maint: update release

Pushed On 17 Oct 2022 at 09:34:09
Started

0xmax

started

Started On 17 Oct 2022 at 09:31:04

0xmax

started

Started On 17 Oct 2022 at 09:27:31

0xmax

maint: add prepare script

Pushed On 17 Oct 2022 at 09:00:22

0xmax

fix: build?

Pushed On 17 Oct 2022 at 08:56:36

0xmax

maint: switch prepare to prepack

Pushed On 17 Oct 2022 at 08:53:19
Create Branch
0xmax In 0xmax/visx Create Branchpublish

0xmax

🐯 visx | visualization components

On 17 Oct 2022 at 08:46:09

0xmax

fix(tooltip): replace findDOMNode with refs for TooltipWithBounds

Pushed On 17 Oct 2022 at 07:02:54
Issue Comment

0xmax

fix(tooltip) replace findDOMNode with refs for TooltipWithBounds

:bug: Bug Fix

This pull request extends the withBoundingRects to use optional refs instead of findDomNode. This should solve the deprecation warning in R18 with strictMode as discussed here To check the fix please enable reactStrictMode: true in next.config.js in the demo package.

This should should not introduce any breaking changes. If the res is not passed, withBoundingRects falls back to findDOMNode. I would appreaciate pointers on how to correctly type the nodeRef in TooltipWithBounds.tsx

Forked On 17 Oct 2022 at 07:01:31

0xmax

Type / lint issues should be resolved.

Commented On 17 Oct 2022 at 07:01:31

0xmax

fix(tooltip) replace findDOMNode with refs for TooltipWithBounds

Pushed On 17 Oct 2022 at 06:59:33
Issue Comment

0xmax

ReactDOM.findDOMNode() in @vx/bounds

Hi, we encountered this warning

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of withBoundingRects() which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
    in div (created by Tooltip)
    in Tooltip (created by TooltipWithBounds)
    in TooltipWithBounds (created by withBoundingRects()) 

Is it possible to replace findDOMNode with a ref in WrappedComponent.componentDidMount here?

Forked On 17 Oct 2022 at 04:34:19

0xmax

Hi, this was a blocking issue for me as well. I have submitted a PR with possible solution here

Commented On 17 Oct 2022 at 04:34:19
Pull Request

0xmax

fix(tooltip) replace findDOMNode with refs for TooltipWithBounds

Created On 17 Oct 2022 at 04:32:42

0xmax

fix(tooltip) replace findDOMNode with refs for TooltipWithBounds

Pushed On 17 Oct 2022 at 04:27:36
Create Branch
0xmax In 0xmax/visx Create Branchdev/replace-findDOMNode-with-ref

0xmax

🐯 visx | visualization components

On 17 Oct 2022 at 04:24:20
Create Branch
0xmax In 0xmax/visx Create Branchdev/findDOMNode

0xmax

🐯 visx | visualization components

On 14 Oct 2022 at 03:57:27

0xmax

🐯 visx | visualization components

Forked On 14 Oct 2022 at 02:48:38
Started

0xmax

started

Started On 14 Oct 2022 at 10:21:44
Issue Comment

0xmax

Automatic WebFont Optimization does not work

What version of Next.js are you using?

10.2.0

What version of Node.js are you using?

14.15.4

What browser are you using?

Chrome

What operating system are you using?

macOS BigSur

How are you deploying your application?

Vercel

Describe the Bug

The font style is not inlined even though I added a link to_document.tsx in the following format. (I'm sure using the Head component exported from next/document)

<Html lang="ja">
  <Head>
    <meta charSet="utf-8" />
    <link  href="https://fonts.googleapis.com/css2?family=Noto+Sans+JP" rel="stylesheet" />
  </Head>
  <body>
    <Main />
    <NextScript />
  </body>
</Html> 

I forked next.js to use a local next.js, and the same thing happened.

When I run 'next build', .next/server/font-manifest.json will be generated, but its contents will be empty. This probably happens only with certain fonts (maybe Japanese font?).

Also, if you run 'yarn dev' after 'yarn build', regardless of whether the font is Japanese or not, the .next/server/font-manifest. json was disappeared, is this a problem?

I found this issue(#19159), but it was already closed and did not solve the problem.

Expected Behavior

The tag is transformed as expected

  • link href property is replaced with data-href of the same value
  • style tag is created with the same data-href key/value
  • style tag contains an inlined font definition

The .next/server/font-manifest.json contains font definitions as fetched from https://fonts.googleapis.com/css...

To Reproduce

  1. Build and start a server from my minimal repo:
git clone https://github.com/Co9xs/next-automatic-webfont-optimization-sample.git
cd next-automatic-webfont-optimization-sample
yarn 
yarn build
yarn dev 
  1. Open http://localhost:3000/
  2. Inspect the of the document
  3. Inspect the built .next/server/font-manifest.json file

Forked On 12 Oct 2022 at 08:28:39

0xmax

Same here, any updates on this?

Commented On 12 Oct 2022 at 08:28:39